Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Readjusts Larva Surgery #6864

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

MPhonks
Copy link
Contributor

@MPhonks MPhonks commented Aug 3, 2024

About the pull request

Currently, the way the larva surgery was written, using the hemostat for the final larva removal step was SLOWER than using ghetto tools such as the wirecutters and fork. This PR aims to fix the issue by making the hemostat the best tool, whilst keeping the original time it took to do so, and readjusts the niche "using one's hands" in an emergency to be the fastest way at the cost of both the doctor's and patient's health.

People used to ghetto surgery on larva will notice it being much slower.

Explain why it's good for the game

It makes no sense for wirecutters and the fork to be faster than using the intended tool. Having the option to make an emergency procedure with one's hands gives doctors a satisfying way of saving their patients from impending chestburst death.

Testing Photographs and Procedure

N/A

Changelog

🆑 MarpleJones
fix: Using the hemostat on the final larva surgery step is now better than using wirecutters or the fork.
add: The final larva surgery step will now apply organ damage when done barehanded. Barehanded is faster than using tools by a couple of seconds, at the cost of the doctor's and the patient's health.
add: Adds an acidsplash sound effect to doing the barehanded step.
/:cl:

@github-actions github-actions bot added Missing Changelog Maintainers always document their changes. Fix Fix one bug, make ten more Feature Feature coder badge and removed Missing Changelog Maintainers always document their changes. labels Aug 3, 2024
@MPhonks MPhonks requested a review from Contrabang August 4, 2024 14:45
code/modules/surgery/chestburster.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 5, 2024 09:33
@MPhonks MPhonks requested a review from harryob August 5, 2024 11:40
@harryob
Copy link
Member

harryob commented Aug 5, 2024

by the way, when maintainers have reviewed something and requested changes, we convert the pr to a draft:
CleanShot 2024-08-05 at 13 54 21@2x

you then have to mark your pr as ready for review again:
CleanShot 2024-08-05 at 13 54 50@2x

otherwise it'll just get lost! obviously no worries this time, though

@harryob harryob marked this pull request as ready for review August 5, 2024 12:55
@harryob harryob added this pull request to the merge queue Aug 5, 2024
Merged via the queue into cmss13-devs:master with commit b424a2b Aug 5, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 5, 2024
@MPhonks MPhonks deleted the larva-surgery-fix branch August 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants